fix: error version judgement#349
Merged
Merged
Conversation
Correct the misnamed macro definition introduced in the previous compilation error fix Log: fix build error
deepin pr auto review代码审查意见:
综合以上意见,建议进行如下修改: void DebListModel::slotUninstallPackage(const int index)
{
// 卸载结束之后 删除指针
connect(transsaction, &Transaction::finished, transsaction, &Transaction::deleteLater);
m_currentTransaction = transsaction; //保存trans指针
// 获取当前真实用户信息
if (ENABLE_VIRTUAL_PACKAGE_ENHANCE) {
QProcessEnvironment env = QProcessEnvironment::systemEnvironment();
QString currentUser = env.value("USER");
QString realUser = env.value("SUDO_USER").toString();
// 如果SUDO_USER存在,说明当前是通过sudo启动的
if (!realUser.isEmpty()) {
currentUser = realUser;
}
// 其他处理...
}
}
void DebListModel::installDebs()
{
m_currentTransaction = transaction;
if (ENABLE_VIRTUAL_PACKAGE_ENHANCE) {
QProcessEnvironment env = QProcessEnvironment::systemEnvironment();
QString currentUser = env.value("USER");
QString realUser = env.value("SUDO_USER").toString();
// 如果SUDO_USER存在,说明当前是通过sudo启动的
if (!realUser.isEmpty()) {
currentUser = realUser;
}
// 其他处理...
}
}以上修改建议旨在提高代码质量、可读性和安全性。 |
max-lvs
approved these changes
Jul 28, 2025
Contributor
Author
|
/merge |
Contributor
|
This pr cannot be merged! (status: unstable) |
Contributor
Author
|
/merge |
Contributor
|
This pr cannot be merged! (status: unstable) |
max-lvs
approved these changes
Aug 9, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LiHua000, max-lvs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the misnamed macro definition introduced in the previous compilation error fix
Log: fix build error